Repository navigation
chore(tooling): fix #869 eslint v8, #870 husky v9, #871 lint-staged v16 and #873 playwright 1.5x - #1255
Merged
Conversation
…juliaife#871 lint-staged v16 and vjuliaife#873 playwright 1.5x
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@Alosnireda Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Deployment failed for project tariff-shield-web with the following error: Learn More: https://vercel.com/docs/concepts/projects/project-configuration |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #869, Closes #870, Closes #871, Closes #873
Overview & System Architecture
This Pull Request modernizes the repository's core developer tooling, static analysis rules, git hook automation, and end-to-end testing infrastructure across four interrelated issues:
Upgrade
@typescript-eslint/eslint-pluginand Parser to v8 (Upgrade @typescript-eslint/eslint-plugin and parser from v7 to v8 #869):@typescript-eslint/eslint-pluginand@typescript-eslint/parserfrom^7.0.0to^8.0.0in the repository rootpackage.json.peerDependenciesinpackages/eslint-config/package.jsonto>=8for both plugin and parser.packages/eslint-config/index.jsfor typescript-eslint v8 compatibility by configuringcaughtErrorsIgnorePattern: "^_", maintaining consistent variable-ignoring behavior withargsIgnorePatternandvarsIgnorePattern.Upgrade Husky from v8.0.3 to v9.x and Migrate Hook Installation Script (Upgrade husky from v8.0.3 to v9.x and migrate hook install script #870):
huskyfrom^8.0.3to^9.1.7in the repository rootpackage.json.preparescript from the deprecated v8 syntax (husky install || true) to the standard v9 CLI invocation ("prepare": "husky")..husky/commit-msgand.husky/pre-committo the modern v9 format by removing the legacy. "$(dirname "$0")/_/husky.sh"sourcing wrapper, leaving direct executable commands (npx --no-install commitlint --edit "$1"andnpx lint-staged).husky.shwrapper are deprecated and cause hook initialization failures in newer Node environments; v9 simplifies hook files into standard shell scripts.Upgrade
lint-stagedfrom v15.2.0 to Latest 16.x Release (Upgrade lint-staged from v15.2.0 to latest 15.x/16.x release #871):lint-stagedfrom^15.2.0to^16.4.0in the repository rootpackage.json.lint-stagedconfiguration schema in rootpackage.jsonto ensure glob matchers and command array tasks conform to v16 specification.prettier --write) run only on staged files via git index stashing without mutating unstaged diffs.engines.node: ">=20".Upgrade
@playwright/testfrom v1.49.0 to Latest 1.5x Release (Upgrade @playwright/test from v1.49.0 to latest 1.5x release #873):@playwright/testfrom^1.49.0to^1.50.1(the latest stable 1.5x release) inapps/web/package.json.npx playwright install chromium, downloading modern Chromium andchromium-headless-shellbuilds (156.0.8078.4/v1248) alongside FFmpeg and winldd utilities.apps/web/playwright.config.tsagainst the 1.5x schema, verifying zero deprecated configuration options..first()acrossdashboard-loads.spec.tsandbond-registration.spec.ts..github/workflows/e2e.yml) and missed trace-viewer and headless runner fixes.Changed
package.json: Upgradedhuskyto^9.1.7(Upgrade husky from v8.0.3 to v9.x and migrate hook install script #870), updatedpreparescript to"husky"(Upgrade husky from v8.0.3 to v9.x and migrate hook install script #870), upgradedlint-stagedto^16.4.0(Upgrade lint-staged from v15.2.0 to latest 15.x/16.x release #871), and upgraded@typescript-eslint/eslint-pluginand@typescript-eslint/parserto^8.0.0(Upgrade @typescript-eslint/eslint-plugin and parser from v7 to v8 #869).package-lock.json: Updated lockfile dependencies to resolve v8 typescript-eslint, v9 husky, v16 lint-staged, and v1.50.1 Playwright.packages/eslint-config/package.json: Raised peerDependencies for@typescript-eslint/eslint-pluginand@typescript-eslint/parserto>=8(Upgrade @typescript-eslint/eslint-plugin and parser from v7 to v8 #869).packages/eslint-config/index.js: AddedcaughtErrorsIgnorePattern: "^_"to@typescript-eslint/no-unused-varsrule configuration for v8 compatibility (Upgrade @typescript-eslint/eslint-plugin and parser from v7 to v8 #869).apps/web/package.json: Upgraded devDependency@playwright/testfrom^1.49.0to^1.50.1(Upgrade @playwright/test from v1.49.0 to latest 1.5x release #873)..husky/commit-msg: Removed legacy. "$(dirname "$0")/_/husky.sh"wrapper for Husky v9 compatibility (Upgrade husky from v8.0.3 to v9.x and migrate hook install script #870)..husky/pre-commit: Removed legacy. "$(dirname "$0")/_/husky.sh"wrapper for Husky v9 compatibility (Upgrade husky from v8.0.3 to v9.x and migrate hook install script #870).Testing
Exact verification commands executed locally:
Test Results:
npm run prepare: Exited 0; git hooks initialized cleanly withouthusky.sh.npm run lint: Exited 0; 0 errors and 0 warnings across@tariffshield/sdk,@tariffshield/api, and@tariffshield/web.npx lint-staged: Exited 0; git stash and staged file formatting completed cleanly.npm run test:e2e: Exited 0; all 6 E2E tests passed in 7.5s.Scope Notes
contracts/tariff-shield), no database schema migrations, and no API business logic modifications.Push Command