fix: first try/guess fixing race of requests - #51
Draft
skoegl wants to merge 1 commit into
Draft
Conversation
skoegl
marked this pull request as draft
April 26, 2024 11:16
Member
|
I tested it with the following config: from viur.datastore.transport import _http_internal
from requests.adapters import HTTPAdapter, DEFAULT_POOLSIZE
from multiprocessing import cpu_count
_http_internal.mount(
"https://",
HTTPAdapter(
pool_connections=max(DEFAULT_POOLSIZE, cpu_count() * 4 * 2),
pool_maxsize=max(DEFAULT_POOLSIZE, cpu_count() * 4 * cpu_count()),
max_retries=3,
)
)In the cloud with the F2 instance this is Google has the following settings: https://github.com/googleapis/google-auth-library-python/blob/8cfc91db0861bc92374d708140656fb38e003ef6/google/auth/transport/requests.py#L409-L410 We should therefore not go below these values in any case. But I haven't noticed any noticeable difference. So you don't have to use it as my configuration. But I find the part with the assert the most interesting anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a draft - not tested yet...