e2e test suite + bunch of bugfixes - #351
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented Playwright e2e test suite.
They're mostly agentic-coded with a few review rounds, but it allows us to introduce new changes more frequently.
Bugs fixed
All fixes ship with regression coverage — e2e
knownbugs/*Spec, jest component tests, or server unit tests — each proven red against the pre-fix code.Consumer session
server/.../ConsumerSessionRunner.scala· regressionCS-10sConsumerSession/Toolbar/Toolbar.tsxsortKey). —ConsumerSession.tsx,sort.tsStartFromInput.tsxExportMessagesButton.tsxForms & validation
CreateTenantPage,ResourceGroupForm(+DeleteDialog),CreateNamespace,CreateSubscription"messageId"), silently creating the subscription at earliest. —CreateSubscription.tsxLibrary
onChangereturned a function instead of calling it) and ignored read-only. —KeyValueEditor.tsxAvailableInContextsButton.tsxserver/.../Library.scalaINVALID_ARGUMENTinstead of a silent empty result; client call sites guard the empty case (no request, empty results, no error toast). —Library.scala,SearchResults.tsx,PickLibraryItemButton.tsxidallowed path traversal (../../xescaped the library root, enabling arbitrary.binpbwrite/delete). Now charset-allowlisted on write/delete; reads unaffected so existing items still load. —Library.scalaNavigation, tables & misc UI
NavigationTree.tsxSubscriptionPage.tsxconsole.log('overlay', …). —HealthCheckContext.tsxt/ns/topic/topic), caused by a dead=== undefinedbranch and a stateful/gregex reused with.test(). —NavigationTree.tsxUnknown credentials type: 4in the list conversion, which broke the entire credentials list from rendering; added the missing conversion case + label. —pulsar-auth/conversions.ts,Editor.tsxgithub.comin an iframe, which GitHub blocks (X-Frame-Options), so it was permanently blank; replaced with a Markdown note linking to the GitHub releases page (opens in a new tab). —Notes/blog-note.tsx,Notes.tsxReclassified (not bugs — intended design, pinned by tests)
DEKAF_DATA_DIR; docker runs one Dekaf per Pulsar). The library dir stays flat; BUG-17's traversal guard is unaffected.Instrumentation (not a user-facing defect)
data-testid(the click handler was already row-correct); suffixed with the role for test addressability. —Permissions.tsx