Strict schema validation, LLM fallback, robust graph builder, and GraphView refactor#3
Draft
vishwateja231 wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
schema_enforcer.pyby disabling the column mapping andautocorrect_sql, tighteningvalidate_sql_columnsto check table-qualified refs and aliases, and keeping an authoritativeSAP_TABLESlist.routers/query.pyto remove mapping injection, stop auto-correct usage, add a single-retry UX for DB errors, change some error messages (e.g. return"Invalid column in query"when SQL generation fails), and add a Gemini-based SQL generation fallback via_gemini_sql_callwhen Groq is rate-limited.graph_builder.pyto be data-driven: introduceENTITY_COLUMN_MAP, normalize values, extract entities per-row (_extract_entities_in_row), create nodes via_make_node, build edges from same-row entity order with a genericrelatedlabel, and produce a fallback record node when no entities found.GraphView.jsxto streamline UI and styling: updateNODE_COLORS, remove the search box and error toast, addstyleGraphto normalize incoming graph payloads, tuned3force parameters, ensure theme-aware styles, and simplify ReactFlow panels and node/edge styling.Testing
schema_enforcerandgraph_buildersmoke tests; checks passed locally with the existing test suite.yarn build) and ran the dev server to verifyGraphViewrenders styled nodes/edges and applies force layout; the build and manual render smoke checks succeeded.Codex Task