Skip to content

feat(effects): add cinematic adaptive HDR bloom - #3000

Merged
ibgreen-openai merged 3 commits into
masterfrom
codex/cinematic-hdr-bloom
Aug 7, 2026
Merged

feat(effects): add cinematic adaptive HDR bloom#3000
ibgreen-openai merged 3 commits into
masterfrom
codex/cinematic-hdr-bloom

Conversation

@ibgreen-openai

Copy link
Copy Markdown
Collaborator

Goals

  • Move reusable luma.gl HDR bloom toward production-quality, deck.gl-friendly post-processing without breaking the existing fixed bloom pipeline.
  • Fix the bloom example's WebGPU scene-texture sampling validation failure.

Changes

  • Generate adaptive two-, three-, four-, or five-level HDR bloom pyramids from low, medium, high, and ultra quality presets.
  • Reconstruct wider levels progressively with matching energy-normalized nine-tap WGSL and GLSL tent filters.
  • Expose configurable scatter, soft highlight knee, luminance-weighted firefly suppression, anamorphic stretch, and RGB tint on createBloomShaderPassPipeline.
  • Preserve the legacy exported three-level bloomShaderPassPipeline and existing compact bloom effect.
  • Give the animated bloom example a texture with both render and sample usage, expose the new quality/cinematic controls, and document the reusable API.
  • Cover every quality level, routing/allocation behavior, normalized reconstruction, anisotropic radii, HDR energy preservation, firefly suppression, and tinted pixel output.

Verification

  • yarn lint fix
  • yarn build
  • PLAYWRIGHT_BROWSERS_PATH=/Users/ib/.cache/ms-playwright yarn test-headless modules/effects/test/passes/image-blur-filters/bloom.spec.ts (6 passing Chromium/WebGPU tests)
  • Production website build and broader example type checks are running locally.

@ibgreen-openai
ibgreen-openai marked this pull request as ready for review August 6, 2026 20:53

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 756e113f86

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ibgreen-openai
ibgreen-openai force-pushed the codex/cinematic-hdr-bloom branch from 756e113 to d5200f0 Compare August 7, 2026 00:37
@ibgreen-openai
ibgreen-openai merged commit 8291081 into master Aug 7, 2026
6 checks passed
@ibgreen-openai
ibgreen-openai deleted the codex/cinematic-hdr-bloom branch August 7, 2026 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants