feat(gltf): support independently animated scenegraph instances - #2991
Draft
ibgreen-openai wants to merge 3 commits into
Draft
feat(gltf): support independently animated scenegraph instances#2991ibgreen-openai wants to merge 3 commits into
ibgreen-openai wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
getScene/getAnimatorintegrations.Changes
createGLTFAnimationInstances,GLTFAnimationInstances,GLTFAnimationInstance, and typed creation/selection options to@luma.gl/gltf.createScenegraphsFromGLTF,GLTFAnimator, engineAnimationMixer,GLTFSkinController, and canonical morph-target path for every isolated character.Verification
node_modules/.bin/tspc -b modules/*/tsconfig.json --pretty false.SimpleSkin.gltf,AnimatedMorphCube.glb, andAnimatedColorsCube.glbregressions prove independent roots, source immutability, skin palettes, GPU buffer bytes, material pointers, clip transitions, timing, pause/reverse, and safe disposal.RobotExpressive.glb: 14 named clips, three simultaneous Dance/Running/Walking characters, two independent 43-joint palettes per character, facial morph targets, an actual 50/50 Dance→Wave crossfade, and safe surviving-instance destruction. The external robot asset is not vendored by this PR.git diff --checkpass.YARN_NO_PROXYis rejected by its installed Yarn configuration; equivalent strict build, 172 tests, both native/software GPU runs, and the complete documentation build were run explicitly before committing. The normal organizational pre-push hook remained enabled.Architecture / Ownership
@luma.gl/gltf; existing rendering, interpolation, shaders, and retained-object packages remain unchanged.masterdirectly.