feat(experimental): add luDF reductions and histograms - #2955
Open
ibgreen-openai wants to merge 2 commits into
Open
feat(experimental): add luDF reductions and histograms#2955ibgreen-openai wants to merge 2 commits into
ibgreen-openai wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 030dece020
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
Add GPU-resident global dataframe reductions and filtered numeric histograms to luDF without implicit batch packing, command submission, or CPU row readback.
Changes
frame.aggregate(definitions)/query.aggregate(definitions)globalcount,sum,min,max, andmeanoperations.float32,sint32, anduint32source types for sum/min/max; exposefloat32means anduint32counts with one-row GPU-owned result tables.frame.histogram(column, {bins, domain})and{edges}variants; keep domains explicit so filters and nullable rows cannot corrupt inferred bounds.GPUReduction,GPUHistogram, andGPUMask; exclude null/NaN/infinite statistic inputs and expose explicit GPU validity flags for every nullable scalar result.Verification
nvm use— Node 22.22.1.yarn install— the existing enterprise registry returns HTTP 403 for an upstream alpha dev-tool package; reused the previously verified ignored workspace dependency tree.yarn lint fix— passed after final source changes.yarn build— passed across every workspace package after final formatting.CI=1 yarn test— Node: 597 passed and one skipped; real Chromium/WebGPU: 1,576 passed and 25 skipped.yarn website:build— passed, including validation of 461 documentation pages.(cd website && yarn build)— passed, including validation of 461 documentation pages.yarn examples:typecheck— passed across all 46 example workspaces.yarn bundle-size— passed all seven existing bundle budgets.Risks and limitations