feat(examples): add interactive GPU-native luGraph explorer - #2954
feat(examples): add interactive GPU-native luGraph explorer#2954ibgreen-openai wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75cd0009f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| this.getVectorBuffer(this.pinned).write( | ||
| Uint32Array.of(1), | ||
| this.selectedVertex * UINT32_BYTE_LENGTH | ||
| ); |
There was a problem hiding this comment.
Wait for pick result before dragging nodes
When a user presses and drags a different node, the pick requested on pointerdown is still asynchronous, so selectedVertex can still be the previous selection (or the initial vertex 0) when pointermove runs. In that case this write pins the old vertex and the following position/velocity writes move it, so quick click-dragging a newly targeted node corrupts the wrong node's layout state; defer drag writes until the pick resolves or track the vertex being dragged separately.
Useful? React with 👍 / 👎.
15de864 to
fc6e621
Compare
5c18358 to
8be314c
Compare
Goals
@luma.gl/experimental/lugraphAPI, ownership contracts, traversal semantics, and website discovery.Changes
Verification
nvm use: passed; Node v22.22.1.yarn install: attempted, but the configured registry denies unpublished/uncached dev-tools dependencies with HTTP 403. Used an isolated APFS copy-on-write clone of an existing compatible dependency tree and ignored Yarn state; no dependency or lockfile changes.yarn lint fix: passed; 1,557 files checked.yarn build: passed after the final picking regression fix.yarn test: 892 Node tests passed, 1 skipped; 1,674 real-browser/WebGPU tests passed, 25 skipped.yarn website:build: passed.(cd website && yarn build): passed.yarn examples:typecheck: passed across 46 example workspaces.yarn bundle-size: all seven bundle ceilings passed.Risks / follow-up
O(V² + E)force layout to 128 vertices; the stacked spatial-acceleration PR adds an explicitly approximate grid-monopole option.