feat(deck): extract reusable luSpatial geographic query effect - #2926
Open
ibgreen-openai wants to merge 6 commits into
Open
feat(deck): extract reusable luSpatial geographic query effect#2926ibgreen-openai wants to merge 6 commits into
ibgreen-openai wants to merge 6 commits into
Conversation
ibgreen-openai
marked this pull request as ready for review
August 4, 2026 08:50
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b019f89a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ibgreen-openai
force-pushed
the
codex/luspatial-direct-source-ids
branch
from
August 4, 2026 14:15
2bd6fe4 to
7f47087
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
from
August 4, 2026 14:20
450a0d9 to
62a3981
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-direct-source-ids
branch
from
August 4, 2026 18:00
7f47087 to
038ef75
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
from
August 4, 2026 18:00
edcba63 to
95fc53f
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-direct-source-ids
branch
from
August 4, 2026 21:38
038ef75 to
63c7fb5
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
from
August 4, 2026 21:39
95fc53f to
f793ee2
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-direct-source-ids
branch
from
August 4, 2026 22:59
63c7fb5 to
c1d2044
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
2 times, most recently
from
August 5, 2026 00:01
2757534 to
f6856ed
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-direct-source-ids
branch
2 times, most recently
from
August 5, 2026 00:39
3240604 to
697adb0
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
from
August 5, 2026 00:39
f6856ed to
01d05bc
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-direct-source-ids
branch
from
August 5, 2026 13:52
697adb0 to
88c6c95
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
from
August 5, 2026 13:52
01d05bc to
a5eb749
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-direct-source-ids
branch
from
August 5, 2026 14:07
88c6c95 to
30f513c
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
from
August 5, 2026 14:07
a5eb749 to
e7ff7d0
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-direct-source-ids
branch
from
August 5, 2026 15:00
30f513c to
844a282
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
from
August 5, 2026 15:00
be10c71 to
d5ca2f9
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-direct-source-ids
branch
from
August 5, 2026 15:10
844a282 to
25c20bb
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
2 times, most recently
from
August 5, 2026 15:24
0539afc to
b66628c
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-direct-source-ids
branch
2 times, most recently
from
August 5, 2026 17:28
1c769d3 to
35e3c3a
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
from
August 5, 2026 17:28
b66628c to
56f1b1d
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-direct-source-ids
branch
from
August 5, 2026 19:30
35e3c3a to
8937bd7
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
2 times, most recently
from
August 5, 2026 20:31
32e3e45 to
74910f2
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-direct-source-ids
branch
from
August 5, 2026 20:31
8937bd7 to
37fd510
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
from
August 5, 2026 21:32
74910f2 to
ca48638
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-direct-source-ids
branch
2 times, most recently
from
August 5, 2026 21:48
a9ad93d to
beee1be
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
from
August 5, 2026 21:48
ca48638 to
1cdcdda
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-direct-source-ids
branch
from
August 5, 2026 22:48
beee1be to
1222740
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
from
August 5, 2026 22:48
1cdcdda to
4be424a
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
3 times, most recently
from
August 6, 2026 00:27
79d2165 to
75ba6ac
Compare
ibgreen-openai
force-pushed
the
codex/luspatial-geographic-query-effect
branch
from
August 6, 2026 02:31
75ba6ac to
6f44ce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
@deck.gl-community/luspatialroot entry isolated from optional query and graph dependencies.Changes
@deck.gl-community/luspatial/queryentry withLuSpatialGeographicPointQueryEffect, typed layer outputs, stable graph/counter IDs, and query statistics.Verification
nvm use— Node 22.22.1.git diff --check— passed.@ts-expect-errorinmodules/core/src/adapter/luma.tswith this shared install.yarn lint fix,yarn build,yarn test,yarn website:build, and(cd website && yarn build)could not start in the isolated worktree because the current dependency install is unavailable;yarn installis blocked locally by registry 403 responses. Clean GitHub CI is the authoritative full gate.Stack
codex/luspatial-direct-source-ids).Risks
destroy()when they remove it outside deck.gl's effect lifecycle.