Benchmark Parquet implementations against latest hyparquet - #3547
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08a4127d62
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function installMockDecompressionStream(options: MockDecompressionStreamOptions): () => void { | ||
| const originalDescriptor = Object.getOwnPropertyDescriptor(globalThis, 'DecompressionStream'); | ||
|
|
||
| class MockDecompressionStream { |
There was a problem hiding this comment.
Add TSDoc to the mock stream class
This introduces a new MockDecompressionStream class (with new readonly fields) without TSDoc; the repo's documented style guidance requires TSDoc on every new class, function, method, and field, so this test helper should get class/field docs before merge.
AGENTS.md reference: AGENTS.md:L33-L33
Useful? React with 👍 / 👎.
Goals
Stack position: #3461 → this PR. The PR targets
codex/native-decompression-stream-support; compared withmaster, it builds on that native-decompression tranche and adds the benchmark changes below.Actual changes
hyparquet 1.27.1, and usehyparquet-compressors 1.1.1.ts-node/esmloader registration that conflicted with the benchmark loader.Validation
yarn lint fixyarn test bench parquetyarn test-node test/bench-loader.node.spec.tsyarn buildyarn test-nodeyarn test-headlessgit diff --check