RFC/POC: support float16 postprocess buffers - #10537
Draft
ibgreen-openai wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Allow deck.gl postprocessing effects to preserve HDR highlight energy before effects such as bloom consume the rendered scene.
Changes
postProcessColorFormattoDeckProps, defaulting to the existingrgba8unormbehavior.rgba16floatpostprocess ping-pong buffers.PostProcessColorFormatfor callers configuring HDR effects.Context
This is intentionally an RFC/POC. luma.gl v10 has HDR-capable WebGPU canvas support, but deck.gl currently clips highlights in its
rgba8unormpostprocess intermediates before a bloom effect can read them. This change provides the deck.gl-side opt-in without changing the default rendering path.Example:
Validation
yarn vitest run test/modules/core/lib/deck-renderer.spec.tsyarn buildyarn lintwas run; it is blocked only by unrelated existing formatting inmodules/core/src/passes/layers-pass.ts.