fix(layers): ColumnLayer flat mode in webgpu - #10535
Merged
Merged
Conversation
ibgreen-openai
approved these changes
Aug 7, 2026
Pessimistress
force-pushed
the
x/column-webgpu-fix
branch
from
August 7, 2026 01:54
b48a776 to
b977baa
Compare
|
Coverage is 83.753% — x/column-webgpu-fix into master. No base build found for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
With
extruded:false, ColumnLayer reuses the same model to draw fill and flat stroke. The model's vertexCount and uniform is swapped out right before the draw call. This does not work on a WebGPU device, where uniform buffer update does not happen synchronously.Change List