Skip to content

fix(carto): render PointLabelLayer backgrounds - #10533

Open
cyphercodes wants to merge 1 commit into
visgl:masterfrom
cyphercodes:fix/point-label-visual-background-10486
Open

fix(carto): render PointLabelLayer backgrounds#10533
cyphercodes wants to merge 1 commit into
visgl:masterfrom
cyphercodes:fix/point-label-visual-background-10486

Conversation

@cyphercodes

Copy link
Copy Markdown

Closes #10486

Change List

  • Keep PointLabelLayer's expanded collision background separate from its visual TextLayer background.
  • Forward visual background color, border, radius, and padding properties.
  • Add unit and golden-image regression coverage.

Testing

  • yarn vitest run --project headless test/modules/carto/layers/point-label-layer.spec.ts
  • yarn vitest run --project render test/render/test-cases/text-layer.spec.ts -t point-label-layer-background
  • yarn test-fast
  • yarn build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] PointLabelLayer does not render TextLayer visual backgrounds

1 participant