feat(core): override size zoom in OrthographicView - #10532
Merged
Conversation
|
coverage: 83.757% (+0.005%) from 83.752% — x/ortho-unit-size into master |
ibgreen-openai
approved these changes
Aug 6, 2026
Collaborator
|
Should there be any doc updates? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
While OrhographicView supports 2D zoom,
project.scaleremains a numeric value. This scaler affects the outcome of any sizeUnit:common, including ScatterplotLayer getRadius, TextLayer getSize, PathLayer getWidth etc.Currently
project.scaleis calculated as2 ** Math.min(zoomX, zoomY). This makes geometry sizes unpredictable when only one axis can be zoomed.This PR allows apps to control the size zoom by supplying their own
zoomvalue. The value is shadowed byzoomXandzoomYduring position projection, but respected during size projection. For all other types of viewports,zoomis used for both position and size projections.Alternative names considered include
sizeZoom, andzoomZ.