Pull Request #2
Open
OpalJellyfish wants to merge 55 commits into
Open
Conversation
vinitha910
requested changes
Apr 4, 2019
vinitha910
requested changes
Apr 4, 2019
vinitha910
reviewed
Apr 9, 2019
vinitha910
left a comment
vinitha910
left a comment
Owner
There was a problem hiding this comment.
Great job! Just very minor stuff. Also, be careful with where you put an extra line between code. The general rule of thumb is to group lines of code that are relevant to one another
|
At least https://chris.beams.io/posts/git-commit/#imperative but also probably fewer single line edit commits too |
nickswalker
suggested changes
Apr 23, 2019
nickswalker
left a comment
nickswalker
left a comment
There was a problem hiding this comment.
I don't know why GitHub lets me make reviews on this but
Be careful not to track editor files. You can add these to the .gitignore if it helps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented Graph and Dijkstra
Even if I made some minor mistakes, please leave me comments about them! I really want to improve my C++ coding skills.