Ext saved reports: localStorage persistence on the SDK (UI SDK 1.13)#824
Closed
vincentmakes wants to merge 1 commit into
Closed
Ext saved reports: localStorage persistence on the SDK (UI SDK 1.13)#824vincentmakes wants to merge 1 commit into
vincentmakes wants to merge 1 commit into
Conversation
vincentmakes
force-pushed
the
claude/ea-savings-tracking-extension-qhh03f
branch
from
fe099ec to
311a8aa
Compare
The SDK's useSavedReport wrapper only re-exported the URL-saved-report layer (config / savedReportId / name) and dropped the core hook's localStorage auto-persist layer that makes every core report survive a browser refresh. Re-export consumeConfig / persistConfig / resetAll from useExtensionSavedReport so an extension report page can keep its filters and selection across a refresh exactly like a core report (URL saved report > localStorage > defaults). Bump UI_SDK_VERSION to 1.13 (additive) and assert the new surface in the saved-report test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MnYtzJEyS2hkAou7CY2pYi
vincentmakes
force-pushed
the
claude/ea-savings-tracking-extension-qhh03f
branch
from
311a8aa to
6b8f327
Compare
Deploying turbo-ea-docs with
|
| Latest commit: |
6b8f327
|
| Status: | ⚡️ Build in progress... |
Owner
Author
|
Superseded by #826 (branch renamed). Closing. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extension report pages could not keep their filters and selection across a browser refresh. The SDK's
useSavedReportwrapper only re-exported the URL-saved-report layer (config/savedReportId/name) and dropped the core hook's localStorage auto-persist layer that makes every core report survive a refresh. This re-exports that layer.Changes
useExtensionSavedReportnow re-exportsconsumeConfig/persistConfig/resetAllalongside the existing fields, so an extension report keeps its state across a refresh exactly like a core report (URL saved report > localStorage > defaults).UI_SDK_VERSIONto1.13(additive — host checks the major only).VERSION→2.12.0,CHANGELOG.md,CLAUDE.md.Test Plan
npx vitest run src/lib/extensionSavedReport.test.tsx src/lib/extensionHost.test.tsx→ 24/24 pass.All CI checks pass
Added/updated tests for new or changed behavior