perf: batch table string insertions - #668
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch generated Typst and HTML content before calling lines_insert(), reducing repeated splitting and collapsing of the growing table string without introducing a parallel line-oriented helper API.
This is a smaller alternative to #666. It keeps the existing lines_insert() abstraction and changes only the hot call sites:
Benchmarks
Median build_tt() rendering time, measured in separate main and simpler666 worktrees after warm-up. Primary cases used 30 iterations.
Verification
The issue #592 snapshot is covered and remains byte-for-byte unchanged.