perf(style_tt): batch @style accumulation instead of per-call rbind - #667
Merged
vincentarelbundock merged 2 commits intoJul 11, 2026
Merged
Conversation
style_tt_lazy() previously grew @Style with an incremental rbind() on every style_tt() call. That per-call rbind() is O(N^2) in the number of style calls and dominated the lazy-style evaluation phase on tables with many style_tt() calls (e.g. per-cell heat-maps, alternating row backgrounds). style_tt_lazy() now exposes only the current call's settings frame in @Style; build_tt() collects those frames and rbind()s them once at the end of the lazy loop. Output is byte-for-byte identical (verified across 14 fixtures x 4 formats and the full tinytest suite). End-to-end save_tt() speedup scales with the number of style_tt() calls: heavy (60x12, 165 calls) typst 1.14x / html 1.08x stress (100x15, 473 calls) typst 1.20x / html 1.22x
Owner
|
thanks a lot! merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR and the code changes are entirely "vibe coded" using GLM-5.2.
style_tt_lazy()previously grew@stylewith an incrementalrbind()on everystyle_tt()call. That per-callrbind()is O(N^2) in the number of style calls and dominated the lazy-style evaluation phase on tables with manystyle_tt()calls (e.g. per-cell heat-maps, alternating row backgrounds).style_tt_lazy()now exposes only the current call's settings frame in@style;build_tt()collects those frames andrbind()s them once at the end of the lazy loop. Output is byte-for-byte identical (verified across 14 fixtures x 4 formats and the full tinytest suite).End-to-end
save_tt()speedup scales with the number ofstyle_tt()calls: