Clean up sample app debug screen#598
Open
FegzDev wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @vinceglb,
This PR correctly sets the name of the folder picker button on the DebugScreen to "Pick Folder" rather than "Pick File".
It also resets the folder picker's buttonState to AppScreenHeaderButtonState.Enabled in it's onResult block. However, I would like to point out that the nonWeb implementation of the debugPlatformTest function is such that calling it on the same folder twice will throw an exception if the previously created savedDir is still present in the folder.
Lastly, this PR comments out an unused file picker on the same screen as I am not fully certain what it is for.
I look forward to your feedback.