tools_calibrate: use raw trigger Z for probe offset - #173
Open
orion23rigel wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TOOL_CALIBRATE_PROBE_OFFSET currently reads index [2] from the probe session result when calculating the new probe z_offset.
With Klipper's current probe session result type, that value is the offset-adjusted bed Z. If a probe z_offset is already configured, it is applied before the calibration math runs, causing repeated calibration to alternate between the real offset and approximately zero.
This changes the calibration to use probe_result.test_z, the raw trigger/toolhead Z position, so the existing configured probe z_offset is not folded into the new result.
Testing
Tested on a toolchanger setup where repeated TOOL_CALIBRATE_PROBE_OFFSET runs previously alternated between approximately -0.17 and 0.00. After this change, repeated runs remained consistent around the expected value.
Also ran: