fix: don't require downstream bon dependency for components#222
Open
dvaergiller wants to merge 1 commit into
Open
fix: don't require downstream bon dependency for components#222dvaergiller wants to merge 1 commit into
dvaergiller wants to merge 1 commit into
Conversation
Make the default builder for the `#[renderable]`/`#[component]` macro set the `#[builder(crate = ::hypertext::bon)]` parameter so that projects using the macros do not have to add bon to its own dependencies. Without the `crate` parameter, the macro will expand to code that directly refereces bon. If the user of the macro does not have bon as a direct dependency it will generate the following error: ``` 41 | #[renderable] | ^^^^^^^^^^^^^ could not find `bon` in the list of imported crates ``` This adds the `crate` parameter when not setting the builder directly. The DefaultBuilder works without it. But if one was to explicitly set `#[renderable(builder = hypertext::Builder)]` then one can either keep bon as a direct dependency or set the `crate` parameter manually. That should normally not be necessary since `hypertext::Builder` is the default builder.
Contributor
Author
|
It seems that Miri has stopped working on latest nightly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the default builder for the
#[renderable]/#[component]macro set the#[builder(crate = ::hypertext::bon)]parameter so that projects using the macros do not have to add bon to its own dependencies.Without the
crateparameter, the macro will expand to code that directly refereces bon. If the user of the macro does not have bon as a direct dependency it will generate the following error:This adds the
crateparameter when not setting the builder directly. The DefaultBuilder works without it. But if one was to explicitly set#[renderable(builder = hypertext::Builder)]then one can either keep bon as a direct dependency or set thecrateparameter manually. That should normally not be necessary sincehypertext::Builderis the default builder.