Option: show room success rate colors in chapter graph

[NonbinaryCoder]

Colors the bars in the chapter graph to match the colors established by the "Success Rate Colors" section in "Live-Data Settings"

Enhancements:

• Simplified Chinese translation

Questions:

• Is the setting position and description good?
• Currently, when the setting is enabled the minimum height of bars in the chapter graph is increased to 3 pixels to increase color readability. Is this necessary or does it decrease readability of choke rate too much?
• Currently, success rates have to be recomputed each frame. This could theoretically cause problems on less powerful devices on maps with large numbers of rooms.
  • Adding caching to RoomStats.AverageSuccessOverN would be easy
  • Cache could be kept by GraphOverlay, however I am not familiar enough with the CCT codebase to implement such a feature

[Kongtiao552]

Maybe I can do the Chinese translation for you

[NonbinaryCoder]

That would be nice, thank you! I didn't want to just use an online translator since it would be likely to make mistakes.

[NonbinaryCoder]

It looks to me like UpdateOverlay is called when any stat changes, so I'll work on caching success rates the same way choke rates are

[viddie]

@NonbinaryCoder

• name and description of the setting is good 👍
• 3px min height to see the colors better seems fine i think
• the success rates should definitely be cached. the way to go about that should be similar to how its done in the ChokeRateStat: Keep a dictionary in the SuccessRateStat, have a function to get the data you want to get, which returns the cached dictionary if not null, or computes, caches and returns the data if the cache was null. now a small improvement over my implementation in ChokeRateStat: dont make the cache dictionary public, but add a public function which resets the cache (just sets it to null)

overall a really cool feature tho!

[NonbinaryCoder]

will do! probably over this weekend depending on how busy i end up

[NonbinaryCoder]

I've added caching to the success rate stat, and adjusted the choke rate stat to match how viddle suggested i implement caching. Invalidating the cache in RoomStats.AddAttempt and RoomStats.RemoveLastAttempt seems to work, but lmk if there's somewhere else the cache should be invalidated. I set it to be invalidated on run end and when changing chapter to match the choke rate stat.

[NonbinaryCoder]

After some testing i've found a bug where changing settings such as thresholds for different colors doesn't cause the graph to update, i will set the cache to be invalidated whenever a setting is changed since the performance impact should be negligible in menus.

[viddie]

Do @ me after you fixed that bug

[NonbinaryCoder]

@viddie I've set the cache to be invalidated in Events.OnAfterSavingStats, which fixes the bug.

[viddie]

i tested the changes, and at least performance wise they seem good. however, i dont like how the setting forces you to also use the explicit indicator for which room you are in. if you can find a solution to make it also work with the default indicator style, i would merge this.

when you've made the changes, re-request the review on this PR.

[NonbinaryCoder]

This good?