Skip to content

chore: setup quality gates with ESLint, Prettier, and CI workflow - #66

Closed
Vaibhav-sa30 wants to merge 3 commits into
vicharanashala:mainfrom
Vaibhav-sa30:feature/quality-gates
Closed

Vaibhav-sa30 wants to merge 3 commits into
vicharanashala:mainfrom
Vaibhav-sa30:feature/quality-gates

Conversation

@Vaibhav-sa30

@Vaibhav-sa30 Vaibhav-sa30 commented Jul 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

This PR establishes the foundational quality gates for the Tenali codebase by introducing standardized formatting, linting, contribution guidelines, and automated CI checks to improve code consistency and maintainability.

Changes Introduced

ESLint Integration

  • Configured ESLint across the project (root and client).
  • Integrated ESLint with Prettier.
  • Converted existing non-critical issues to warnings to establish a clean baseline with 0 lint errors, allowing future contributions to be held to a stricter standard without blocking the current codebase.

Prettier Setup

  • Added .prettierrc and .prettierignore.
  • Standardized code formatting across the repository.
  • Auto-formatted all existing source files.

GitHub Actions (CI)

  • Added .github/workflows/ci.yml.
  • Automatically runs the following checks on every Push and Pull Request:
    • npm run lint
    • npm run build
    • npm run test
  • Environment targets Node.js 22 LTS to avoid deprecation warnings.

@Vaibhav-sa30
Vaibhav-sa30 force-pushed the feature/quality-gates branch from 886601e to b11da12 Compare July 17, 2026 11:36
@Vaibhav-sa30
Vaibhav-sa30 force-pushed the feature/quality-gates branch 6 times, most recently from 0e7f355 to 92b9c9e Compare July 28, 2026 00:08

@S-Hamsalekha-annamai S-Hamsalekha-annamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the actual formatting / linting updates in a separate commit. Lets restrict the first commit to only include the scripts and code changes that implement the quality gates. The remaining changes can come in the second commit.

Comment thread client/src/components/KeyTerms.jsx
Comment thread client/src/detective-app.jsx
Comment thread client/src/detective.test.jsx
@Vaibhav-sa30
Vaibhav-sa30 force-pushed the feature/quality-gates branch 2 times, most recently from f7db54a to d0e4d49 Compare July 28, 2026 15:17
@muditagrawal2007

Copy link
Copy Markdown
Collaborator

:sipmap /help

@sipmap

sipmap Bot commented Aug 22, 2026

Copy link
Copy Markdown

👋 Hi! I'm sipmap, your friendly contributor helper.

Commands anyone can run:

Command What it does
:sipmap /help Show this message
:sipmap /test Run process-testing digest on this PR/issue
:sipmap /status Summarize CI check runs
:sipmap /lint Lint PR contents
:sipmap /describe Validate description against template
:sipmap /size Flag oversized PRs
:sipmap /secrets Heuristic secret scan
:sipmap /deps Detect dependency changes
:sipmap /branch Validate branch name
:sipmap /commits Validate commit messages
:sipmap /title Validate PR/issue title
:sipmap /docs Check docs updated for code changes
:sipmap /tests Check tests updated for source changes
:sipmap /approvals Show approval status
:sipmap /claim Self-assign this issue
:sipmap /unclaim Release this issue
:sipmap /thanks @user Manual kudos
:sipmap /metrics @user Show contributor stats
:sipmap /label-list List all repo labels
:sipmap /contributors Top 10 contributors by merged PRs

Maintainer commands (require maintain/admin access):

Command What it does
:sipmap /assign @user Assign reviewer
:sipmap /unassign @user Remove reviewer
:sipmap /good-first-issue Apply good first issue label
:sipmap /help-wanted Apply help wanted label
:sipmap /label <names> Apply labels
:sipmap /unlabel <names> Remove labels
`:sipmap /priority <low med
:sipmap /review Ping maintainers
:sipmap /note <text> Add a maintainer note
:sipmap /close Close with reason
:sipmap /reopen Reopen with reason
:sipmap /lock Lock conversation
:sipmap /pin Pin to repo
:sipmap /duplicate #N Close as duplicate of #N
:sipmap /wontfix [reason] Close as won't fix
:sipmap /invalid [reason] Close as invalid
`:sipmap /merge [merge squash
:sipmap /draft Convert PR to draft
:sipmap /ready Mark PR ready for review
:sipmap /rebuild Re-run failed CI checks
:sipmap /cleanup-stale Close stale issues (>60d)
:sipmap /weekly-digest Post weekly contributor digest
:sipmap /config Show effective config

Drop a .sipmap.yml in your repo to customize behavior. See docs/config.md.

@muditagrawal2007

Copy link
Copy Markdown
Collaborator

:sipmap /lint

@sipmap

sipmap Bot commented Aug 22, 2026

Copy link
Copy Markdown

🔍 sipmap /lint

  • Conflict markers: ✅ none
  • Secret patterns: ❌ 1 suspect
  • Large files (>500KB): ✅ none

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

⏳ This PR has had an unresolved merge conflict with the base branch for over 24 hours. If this isn't resolved within another 24 hours, this PR will be automatically closed — you're welcome to reopen once it's addressed, or resubmit fresh referencing the same issue.

@github-actions

Copy link
Copy Markdown
Contributor

🔒 Closing this PR automatically: it has had an unresolved merge conflict with the base branch for over 48 hours. This isn't a judgment on the work — it's the 48-hour rule from the PR SOP, applied the same way to every PR. Fix the issue above and open a fresh PR referencing the same Closes #N whenever you're ready.

@github-actions github-actions Bot closed this Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants