Repository navigation
feat(scoring): implement atomic recordEvent() ledger writer (#90) - #399
Open
lucky-pluton wants to merge 1 commit into
Open
lucky-pluton wants to merge 1 commit into
lucky-pluton wants to merge 1 commit into
Conversation
Contributor
✅ Parikshak — all automated checks pass
This is Parikshak, an automated, comment-only check — it never closes or approves a PR. A human reviewer still makes the final call. See |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90 — Part of the #87 scoring-ledger epic.
TL;DR
Replaces lost-update read-modify-write patterns with a centralized
ecordEvent(userId, event)\ ledger writer that mutates user scores atomically using MongoDB \\ and \\ operators.
Changes
ecordEvent(userId, event)\ which looks up reward calculations from \scoring.js\ and executes atomic \indOneAndUpdate\ updates.
Verification
pm test\ in \server/: all tests passed (191 tests).
px vitest run tests/ledger.test.js: 4/4 tests passed including concurrency test.