Repository navigation
fix: use consistent 2 d.p. rounding in answer checks (closes #179) - #396
Open
jindal-sneha wants to merge 1 commit into
Open
jindal-sneha wants to merge 1 commit into
jindal-sneha wants to merge 1 commit into
Conversation
Contributor
✅ Parikshak — all automated checks pass
This is Parikshak, an automated, comment-only check — it never closes or approves a PR. A human reviewer still makes the final call. See |
|
🎉 Welcome @jindal-sneha — this looks like your first pull request in this repo! A few friendly tips:
If you get stuck, ask away in the PR comments. Good luck! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #179
Problem
Answer validation and displayed answers used different rounding rules:
46.10was accepted but feedback showed46.08, because the check allowed a tolerance of 0.5.43and expected43.13.Changes
server/routes/geometry.js(mensur check): compare answers rounded to 2 d.p. instead of a 0.5 tolerance.server/routes/misc.js(cyclist average-speed question): clarified wording to "Give your answer correct to 2 decimal places." and changed the check to compare at 2 d.p. instead of a 0.05 tolerance.Testing
46.10vs46.08is rejected,46.08is accepted;43vs43.13is rejected,43.13is accepted.