Repository navigation
Conversation
Vaibhav-sa30
left a comment
There was a problem hiding this comment.
It seems a lot of older code files are being re-introduced in this PR. Kindly, resolve the merge conflicts by syncing your local repo with the upstream and update your PR as per review comments.
There was a problem hiding this comment.
You can either complete the integration of the comics feature in this PR, or remove the related files and submit them in a separate PR. Former is suggested in case you plan to continue working on comic feature. Or else, simply remove them as neither comics.js nor the jpeg asset are imported, referenced, or integrated anywhere else in the application.
Either ways u should remove this 1.7 MB of dead weight.
|
Hi — thank you for this contribution, and apologies for how long it has been waiting. This PR currently conflicts with To be clear, the underlying problem is on our side, not yours. If the rebase turns out to be painful or unmanageable, please just say so here and we will help you through it — we would much rather do that than leave your work sitting. Thanks again for your patience. One suggestion that may save you time: your |
|
No description provided. |
|
Thank you for this contribution. We have not yet done a full review of this pull request, since it currently has a merge conflict with the main branch. Kindly pull the latest main branch into your branch and resolve the conflict at your end. Also, we could not find a linked issue in the pull request description. Kindly link the issue this pull request is meant to resolve, using "Closes #N", so that it can be tracked properly. If there is no existing issue for this work, kindly open one describing the motivation before we proceed with a review. Once the conflict is resolved and the issue is linked, we will proceed with a full review. |
|
⏳ This PR has had requested changes open with no new commits addressing them, for over 24 hours. If this isn't resolved within another 24 hours, this PR will be automatically closed — you're welcome to reopen once it's addressed, or resubmit fresh referencing the same issue. |
|
⏳ This PR has had an unresolved merge conflict with the base branch for over 24 hours. If this isn't resolved within another 24 hours, this PR will be automatically closed — you're welcome to reopen once it's addressed, or resubmit fresh referencing the same issue. |
|
🔒 Closing this PR automatically: it has had requested changes open with no new commits addressing them for over 48 hours. This isn't a judgment on the work — it's the 48-hour rule from the PR SOP, applied the same way to every PR. Fix the issue above and open a fresh PR referencing the same |
|
|
Hi Riddhima, Reopening this one — sorry it got auto-closed for staleness before we could get it over the line. The feature itself was never in question, it was purely the Whenever you get a chance, could you rebase this branch onto the latest Thank you for your patience, and for the work that went into this. |
|
🔒 Closing this PR automatically: it has had an unresolved merge conflict with the base branch for over 48 hours and it has had requested changes open with no new commits addressing them for over 48 hours. This isn't a judgment on the work — it's the 48-hour rule from the PR SOP, applied the same way to every PR. Fix the issue above and open a fresh PR referencing the same |
Feature Overview
Feature Name: World Without Me & Boxed Letters Language Puzzle
Author: Riddhima Deshmukh --> ridds-io
Problem
Students need engaging, multi-disciplinary tools to build their skills:
Solution (Feature Description)
Introduced two major features to enhance interactive learning:
Boxed Letters Puzzle Game
A new interactive word puzzle designed to test vocabulary and spatial reasoning.
A World Without Me - Concept Relevance Dictionary
An imaginative content dictionary that explains the real-world impact of mathematical concepts.
animationType(e.g., 'collapse', 'chaos'), and animpactLevel(funny, serious, catastrophic).User Interaction & Style
Technical Implementation & Architecture
api.dictionaryapi.dev) for real-time dictionary lookups. Custom SVG rendering logic handles coordinate mapping for letter nodes and connection lines.WORLD_WITHOUT_ME) mapping concept keys to metadata. Includes a safe getter (getWorldWithoutMe) with console warnings and null fallbacks to gracefully handle missing topics without breaking the UI.Technical & Quality Checklist
catchblock to allow offline play.getWorldWithoutMehandles unknown keys safely.Verification & Acceptance Criteria
1. Manual Validation Steps
Boxed Letters:
World Without Me:
getWorldWithoutMeand verify it returnsnulland logs a warning instead of crashing.2. Local Build & Tests
npm run devbuilds successfully without warnings.Feature Demo
Boxed Letters:
World Without Me: