Repository navigation
chore: remove signature save debug logging - #193
Open
sandeep-2536 wants to merge 2 commits into
Open
sandeep-2536 wants to merge 2 commits into
sandeep-2536 wants to merge 2 commits into
Conversation
Leftover browser-console logs exposed request/payload details each time a signature was saved in production.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was there
SignatureTool.tsxhad leftover development debug logging that ran every time auser saved a signature. It logged the original file size, the outgoing payload
size, and request content-type/content-length details straight to the browser
console:
console.log('Original file size:', originalSize);
console.log('Payload size:', payloadSize);
console.log('Content-Type:', contentType);
console.log('Content-Length:', payloadSize);
This looked like instrumentation left over from development that was never
cleaned up before the feature shipped — it exposed internal request details
in the production console on every signature save.
Fix
console.logstatementsoriginalSizestate variable, which existed only to feed theselogs and had no other use in the component
before, just without the console noise
How this was found
Found via manual code review of the Tee signature flow, not from an assigned
GitHub issue.
Testing
SignatureTool.test.tsxcovering the upload-and-save flow to confirmbehavior is unaffected by this cleanup
request still succeeds and the debug logs no longer appear in console
pnpm exec tsc --noEmitpassespnpm test— newSignatureTool.test.tsxpasses. Note: 3 unrelated testsuites (
api.test.ts,PremiumTee.test.ts,GoldenTicketDetailPage.test.tsx)fail on
mainas well, due to a pre-existing tooling error(
jsTokens is not a function) unrelated to this change.