Repository navigation
fix(search): respect configured vector threshold in applySearchThreshold - #188
Open
mdsahidraza174-netizen wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR fixes
applySearchThresholdso that it respects the configuredsearch.hybrid.minScorevalue instead of relying on a hardcoded threshold. It also updates the configuration defaults and adds tests to verify the configurable threshold behavior.Related issue
Closes #168
Type of change
Area affected
/admin/*)/community— posts, comments, auto-answer)CI verification
cd apps/backend && npx tsc --noEmitexits 0cd apps/backend && npx vitest run— all tests passcd apps/frontend && npx tsc --noEmitexits 0cd apps/frontend && npx vitest run— all tests passpnpm run lint— 0 errors (152 warnings is the baseline)main, no merge commitsNotes for reviewer
search.hybrid.minScore's default was updated from0.3to0.80to match the previously hardcoded threshold, so this change preserves the existing default behavior while making the threshold configurable. Frontend and documentation were intentionally left unchanged because this PR is limited to the backend fix for issue #168.