Repository navigation
fix(search): make vector similarity threshold configurable via AppSet… - #187
Open
Abhhiiissshhek wants to merge 1 commit into
Open
Abhhiiissshhek wants to merge 1 commit into
Abhhiiissshhek wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR fixes Issue #168 by making the vector similarity threshold configurable through the existing AppSetting infrastructure instead of using a hardcoded value (
0.80).The search controllers now read the threshold from AppSettings and pass it to
applySearchThreshold(), while preserving backward compatibility through the existing default value. Regression tests have also been added for configurable threshold behaviour.Related issue
Closes #168
Type of change
Area affected
/admin/*)/community)CI verification
cd apps/backend && npx tsc --noEmitexits 0cd apps/backend && npx vitest run— unrelated existing Journey Tracks tests currently failcd apps/frontend && npx tsc --noEmitcd apps/frontend && npx vitest runpnpm run lintmainNotes for reviewer
searchVectorThresholdto the existing AppSetting system.0.80) for backward compatibility.