Skip to content

Add optional JSON responses - #21

Merged
vicentereig merged 1 commit into
vicentereig:mainfrom
hxu:hxu/sync-optional-json
Jun 28, 2026
Merged

vicentereig merged 1 commit into
vicentereig:mainfrom
hxu:hxu/sync-optional-json

Conversation

@hxu

@hxu hxu commented Jun 28, 2026 •

Copy link
Copy Markdown

Why: some Garmin endpoints legitimately return empty or no-content responses, and sync should handle those without treating them as malformed JSON.

Example:

Mode: Backfill
Queued tasks: activities 1219, gpx 975, health 4228, performance 604

Large historical backfills query thousands of old health/performance dates; some optional Garmin endpoints have no payload for valid dates.

Changes:

  • Add optional JSON GET support to the Garmin client.
  • Improve JSON parse errors with response context.
  • Add request logging plumbing used by sync diagnostics.

@vicentereig
vicentereig merged commit 01efd4f into vicentereig:main Jun 28, 2026
1 check passed
@exe-dev-github-integration
exe-dev-github-integration Bot deleted the hxu/sync-optional-json branch July 22, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants