Repository navigation
Remove DuckDB dependency in collecting devices - #16
Merged
Merged
Conversation
Owner
|
Good stuff, I appreciate the patience and the time spent! Classic case where the compiler keeps you alive long enough to regret starting the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @vicentereig , I'd like to contribute to this project as I was using it to sync down my data, however it gets stuck somewhere in the sync. That led me to try to build the project, but it took forever because of the duckdb dependency. I am new to Rust, but it seems like it tries to compile duckdb from source which takes over an hour on a machine with two cores.
It looks like duckdb is only used for this one function, and we can implement it with the native store so that we don't have this dependency.
Let me know if you'd like me to adjust anything or if there are any other guidelines for contributing!