chore(actions): Bump actions/upload-artifact from 4 to 7 - #4
Open
dependabot[bot] wants to merge 1 commit into
Open
chore(actions): Bump actions/upload-artifact from 4 to 7#4dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
jamesyong-42
added a commit
that referenced
this pull request
Apr 17, 2026
Walker output under Parallelism::Serial happens to preserve parent-before-child DFS order, but Parallelism::RayonNewPool(n) does not. Any caller using parallelism > 1 and piping the result into populate_store silently produced a corrupt tree: children whose parent hadn't been seen yet got parent_id = None and became spurious roots, with their would-be ancestors never accumulating their sizes. Fix: build a Vec<&WalkedEntry> sorted by (depth asc, path asc) before the insertion loop. O(n log n); trivial vs walker's existing I/O cost. Tests cover both shuffled-input and real parallel walk. Audit finding: High #4 (promoted from Medium during review). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jamesyong-42
added a commit
that referenced
this pull request
Apr 18, 2026
Previously entries: Vec<MutationIntent> grew without bound — record()
only appended, consume() skipped expired entries but never removed them,
and sweep() had to be called externally. Under burst writes (200+
events/sec during npm install / cargo build) with infrequent sweeps,
the vec accumulated stale entries and each consume() linear-scanned
O(n) over them — total O(n²) per batch.
Fix:
- MAX_ENTRIES cap (4096); record() drops oldest on overflow so memory
stays bounded regardless of caller sweep cadence.
- consume() auto-sweeps expired entries at the start so the scan window
stays short even without external sweeps.
Audit finding: Phase 3/4 review #4 (Critical).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/upload-artifact from 4 to 7.
Release notes
Sourced from actions/upload-artifact's releases.
... (truncated)
Commits
043fb46Merge pull request #797 from actions/yacaovsnc/update-dependency634250cInclude changes in typespec/ts-http-runtime 0.3.5e454baaReadme: bump all the example versions to v7 (#796)74fad66Update the readme with direct upload details (#795)bbbca2dSupport direct file uploads (#764)589182cUpgrade the module to ESM and bump dependencies (#762)47309c9Merge pull request #754 from actions/Link-/add-proxy-integration-tests02a8460Add proxy integration testb7c566aMerge pull request #745 from actions/upload-artifact-v6-releasee516bc8docs: correct description of Node.js 24 support in READMEYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)