chore(actions): Bump actions/setup-node from 4 to 6 - #3
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4 to 6. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v6) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
jamesyong-42
added a commit
that referenced
this pull request
Apr 17, 2026
remove() was reading its vis/size contribution from the descendant cache slot, which holds the subtree TOTAL (self + all descendants). Subtracting the total from ancestors while leaving children's cache entries intact made ancestor summaries silently wrong under repeated remove-dir-without-remove-children sequences. Fix: compute self contribution directly from the Entry being removed (+1 if visible, +entry.size). Children's cache entries, if any, are unchanged and remain reachable for later individual removal. saturating_sub was masking the drift. rename() was updating path_to_id only; Entry.name stayed stale. Now rename clones the Entry, updates its name, reinserts the Arc, and re-sorts the affected parent's children slot (since sibling order is by name). Directory rename still returns EUNSUPPORTED until Phase 2's deferred walker-driven recursive rename lands. path_to_id update now happens AFTER snapshot publish, matching insert()'s ordering. Audit findings: Critical #1, Critical #3. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jamesyong-42
added a commit
that referenced
this pull request
Apr 18, 2026
Previously every lock site in watcher.rs used .expect("mutex poisoned")
so a panic anywhere while holding a lock (user callback panic, notify
internals, allocation failure) turned the entire Watcher into a panic
landmine — every subsequent watch / unwatch / watched_roots call crashed
the caller instead of returning the Result<_, FxError> that the public
API advertises.
Fix: add a lock_recover helper that catches PoisonError and recovers
via into_inner(). The protected data (Vec<PathBuf> of roots, Option<>
handle slots) is safe to observe after a partial write — worst case
is a stale roots list, not memory corruption. Applied at every lock
site, including Drop.
Audit finding: Phase 3/4 review #3 (Critical).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Author
|
Superseded by #20. |
dependabot
Bot
deleted the
dependabot/github_actions/actions/setup-node-6
branch
July 25, 2026 19:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/setup-node from 4 to 6.
Release notes
Sourced from actions/setup-node's releases.
... (truncated)
Commits
53b8394Bump minimatch from 3.1.2 to 3.1.5 (#1498)54045abScope test lockfiles by package manager and update cache tests (#1495)c882bffReplace uuid with crypto.randomUUID() (#1378)774c1d6feat(node-version-file): support parsingdevEnginesfield (#1283)efcb663fix: remove hardcoded bearer (#1467)d02c89dFix npm audit issues (#1491)6044e13Docs: bump actions/checkout from v5 to v6 (#1468)8e49463Fix README typo (#1226)621ac41README.md: bump to latest released checkout version v6 (#1446)2951748Bump@actions/cacheto v5.0.1 (#1449)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)