fix(target): track owned volume attachments#155
Open
Rico Lin (ricolin) wants to merge 1 commit into
Open
Conversation
Record when migratekit attaches an OpenStack volume itself and only detach that recorded attachment during cleanup. This preserves metadata-based auto-attach while avoiding metadata lookup and detach for pre-attached volumes. Assisted-By: OpenAI <noreply@openai.com> Signed-off-by: Rico Lin <rlin@vexxhost.com>
Rico Lin (ricolin)
force-pushed
the
fix/openstack-volume-attachment-ownership
branch
from
8688820 to
9f6c2f9
Compare
|
this fix came based on this report from an user |
Rico Lin (ricolin)
force-pushed
the
fix/openstack-volume-attachment-ownership
branch
from
9f6c2f9 to
3169585
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
go test ./internal/targetPKG_CONFIG_PATH=$HOME/.cache/migratekit/libnbd-1.22.2-prefix/lib/pkgconfig CGO_CFLAGS=-I$HOME/.cache/migratekit/libnbd-1.22.2-prefix/include CGO_LDFLAGS=-L$HOME/.cache/migratekit/libnbd-1.22.2-prefix/lib LD_LIBRARY_PATH=$HOME/.cache/migratekit/libnbd-1.22.2-prefix/lib go test -a ./...