Enable OpenMP runtime for LLVM version 10#10
Open
Shinji-IkariG wants to merge 1 commit into
Open
Conversation
Add option to enable OpenMP runtime for LLVM 10.x builds
There was a problem hiding this comment.
Pull Request Overview
This PR adds conditional logic to enable OpenMP runtime support for LLVM 10.x builds. The change detects when LLVM version 10.* is being built and sets a CMake option to enable OpenMP as a runtime.
Key Changes
- Introduced version-specific logic to enable OpenMP runtime for LLVM 10.x builds
- Added conditional variable assignment for the
LLVM_ENABLE_RUNTIMESCMake option
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+212
to
216
| extra_runtimes_opt="" | ||
| if [[ $llvm_version == 10.* ]]; then | ||
| extra_runtimes_opt='-DLLVM_ENABLE_RUNTIMES=openmp' | ||
| fi | ||
| cmake $source_dir \ |
There was a problem hiding this comment.
The variable extra_runtimes_opt is defined but never used in the cmake command that follows. It should be added as an argument to the cmake command, likely using $extra_runtimes_opt without quotes to allow it to expand properly when non-empty, or be omitted when empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to enable OpenMP runtime for LLVM 10.x builds
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: