Skip to content

docs(readme): improve demo video preview - #20

Merged
jack-arturo merged 1 commit into
mainfrom
docs/robinhood-demo-title-frame
May 29, 2026
Merged

docs(readme): improve demo video preview#20
jack-arturo merged 1 commit into
mainfrom
docs/robinhood-demo-title-frame

Conversation

@jack-arturo

@jack-arturo jack-arturo commented May 29, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the README demo with a newly uploaded MP4 whose first frame is a nonblank title slate
  • render the demo as one video element and move the fallback link to the PR asset comment so GitHub does not auto-render a duplicate video
  • keep generated media/source out of repo history; the PR changes README.md only

Tests

  • uv run --extra dev ruff check .
  • uv run --extra dev ruff format --check .
  • uv run --extra dev pytest -q
  • verified video URL with ranged GET: 206 Partial Content, Content-Type: video/mp4, 3,722,212 bytes
  • verified rendered GitHub README branch view has videoCount=1, one text fallback link, and the simulated-data disclaimer

Breaking Changes
None.

Copilot AI review requested due to automatic review settings May 29, 2026 20:59
@jack-arturo

Copy link
Copy Markdown
Member Author

@jack-arturo
jack-arturo force-pushed the docs/robinhood-demo-title-frame branch from 0de7c86 to 9cfbb35 Compare May 29, 2026 21:01
@jack-arturo
jack-arturo force-pushed the docs/robinhood-demo-title-frame branch from 9cfbb35 to 0255b5e Compare May 29, 2026 21:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Replaces the Markdown link to the demo video with an inline HTML <video> embed plus a text fallback link, so the README renders the demo as a playable preview on GitHub while still providing a clickable fallback.

Changes:

  • Add an HTML <video> element pointing to the existing user-attachments asset.
  • Keep a <p><a> fallback link to the same asset for renderers that don't support <video>.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jack-arturo
jack-arturo merged commit 5f9feef into main May 29, 2026
10 checks passed
@jack-arturo
jack-arturo deleted the docs/robinhood-demo-title-frame branch May 29, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants