Skip to content
This repository was archived by the owner on Aug 20, 2026. It is now read-only.

Add ignore error rule for env usage outside config directory in PHPStan #34

Merged
adrianmejias merged 1 commit into from
Apr 4, 2026
Merged

Add ignore error rule for env usage outside config directory in PHPStan #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ parameters:
tmpDir: build/phpstan
checkOctaneCompatibility: true
checkModelProperties: true
ignoreErrors:
- "#Called 'env' outside of the config directory which returns null when the config is cached, use 'config'#"
Comment on lines +12 to +13

Copilot AI Apr 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignoreErrors here globally suppresses the Larastan/PHPStan warning about calling env() outside the config directory. A repo-wide search shows env( is currently only used inside config/cloudflare-turnstile.php, so this ignore appears unnecessary and will reduce static analysis signal by allowing future env() usage in src/ to slip through unnoticed.

Suggestion: remove this ignore rule, or (if you’re addressing a known false-positive) scope it tightly using an ignoreErrors entry with message + path (and ideally count) so new occurrences still fail CI.

Suggested change
ignoreErrors:
- "#Called 'env' outside of the config directory which returns null when the config is cached, use 'config'#"

Copilot uses AI. Check for mistakes.
Loading