Avoid system_limit crash on very large BVV gaps#3
Open
mattwaw67 wants to merge 1 commit into
Open
Conversation
add_aux/2 built the "seen" bitmap with `1 bsl (M-N-1)`. When the gap
between the entry base N and the incoming dot M is huge (millions),
this allocates a multi-megabit bignum and crashes the emulator with
{system_limit, ...}.
Cap the shift: when the gap exceeds MAX_BSL_BITS, advance the base
directly to {M, 0} instead of materialising a giant bitmap.
mattwaw67
force-pushed
the
fix/bvv-large-gap-system-limit
branch
from
ea8168f to
758d346
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_aux/2 built the "seen" bitmap with
1 bsl (M-N-1). When the gapbetween the entry base N and the incoming dot M is huge (millions),
this allocates a multi-megabit bignum and crashes the emulator with
{system_limit, ...}.
Cap the shift: when the gap exceeds MAX_BSL_BITS, advance the base
directly to {M, 0} instead of materialising a giant bitmap.