Prepare v1.2.0-rc.1 qualitative battery UX - #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Critical,Low,Medium,High, andTopacross the tray, tooltip, local API, diagnostics, and Rainmeter.0x06isTop / Charging, while confirmed active-to-inactive0x06becomesTop / Charged.Criticalhandling without changing the existing active EF stability filter.1.2.0.0/1.2.0-rc.1and teach the tag workflow to publish suffixed versions as GitHub prereleases.Why
Space Station uses five ordinary battery presentations plus a special charging glyph. Real Dock captures also show that raw state, charging activity, physical LED colour, controller presence, and completed charge are separate signals. The previous percentage-oriented presentation conflated those concepts and allowed short HID/Dock transitions to flash unavailable or Critical states.
Impact
The tray and Rainmeter now present source-independent qualitative levels. The local status API removes
percentandestimated, so consumers must useschemaVersion: 4,bandLevel,band,charging, andpower.Validation
VaderBatteryTray/build.cmdVaderBatteryTray/build_led_protocol_test.cmdVaderBatteryTray/VaderLedProtocolSelfTest.exegit diff --checkVaderBatteryTray-1.2.0-rc.1.zipD7A9766A9862DE1CBB0211A27B8D572B77328D12C4627DA340329E352A32CA230x04High/Charging, firmware yellow pulse, and suppression of transient0x01Critical.