Keep the tray menu responsive during HID polling - #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The synchronous refresh path could wait several seconds for controller or Dock
HID reports while running on the Windows message loop. If a right-click landed
during that work, the tray context menu could not open until the timeout
completed.
Impact
The tray menu remains responsive while a controller wakes, the Dock is quiet,
or HID reads time out. The last published battery state remains visible until
the background refresh completes.
Validation
/warn:4.VaderLedProtocolSelfTest.exesuccessfully.git diff --checksuccessfully.