feat: use exn said as the notification id - #14
Open
Sotatek-Patrick-Vu wants to merge 1 commit into
Open
Conversation
Sotatek-Patrick-Vu
force-pushed
the
feat/exn-said-notification-id
branch
from
September 3, 2026 11:59
55b6fc8 to
d8552d6
Compare
iFergal
reviewed
Sep 4, 2026
| # a second notice for the same exn keeps the id even though the datetime moves | ||
| other = notifying.notice(attrs=payload, rid=said, dt="2022-07-08T15:01:05.453632") | ||
| assert other.rid == said | ||
| assert other.datetime != note.datetime |
Collaborator
There was a problem hiding this comment.
Does this impact notifications received on Signify side, or this is an internal test? (i.e. .add de-dups stopping this)
Collaborator
|
@jimcase currently investigating what changes (if any) in Veridian Wallet required if we make this change (should be none I think) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the SAID as the notification id, so a re-delivered
exnproduces one notification instead of one per delivery.