fix: clear stale exn escrows after signature check to avoid race conditions - #10
Merged
AABelkhiria merged 3 commits intoJul 23, 2026
Merged
Conversation
AABelkhiria
changed the title
iFergal
approved these changes
Jul 23, 2026
iFergal
left a comment
iFergal
left a comment
Collaborator
There was a problem hiding this comment.
Unsure why macos-15 is failing
Collaborator
|
Sorry, yes, failing due to libsodium now (already forgot from before lunch lol) |
Author
|
yep |
iFergal
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exn escrows have a short, 10 second timeout to clear. Currently, the signatures are not being cleared properly from the database. As a result, other signatures can arrive after the 10 second limit and the exn will verify.
However, if the final threshold signature arrives right as the previous escrow is being timed out, we lose the escrow, despite the database having sufficient signatures.
The fix: Time out escrows after checking the signature threshold count. A better long term solution would be to increase the escrow timeout to better reflect human activity in groups, but for now this is a safer option.