E2E: run CSI snapshot tests on kind CI - #10274
Open
YO-WHATS-UP2 wants to merge 1 commit into
Open
Conversation
The kind matrix excludes every Snapshot and CSI label because the cluster has no CSI driver, so the CSI tests that already exist have never run. This installs the external-snapshotter CRDs, the snapshot-controller and csi-driver-host-path, then adds a job that runs the BackupVolumeInfo CSI labels against them. The kind StorageClass moves to the hostpath provisioner in the same change: local-path cannot snapshot, and switching it before the driver is installed would leave PVCs unbound in the jobs that pass today. Signed-off-by: Sairam Bisoyi <sairamb2007.21@gmail.com>
👷 Deploy request for velero pending review.Visit the deploys page to approve it
|
Contributor
Author
|
/kind changelog-not-required |
YO-WHATS-UP2
force-pushed
the
csi-e2e-kind-ci
branch
from
August 14, 2026 14:51
3c3977f to
16ea67f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
Thanks for this, @YO-WHATS-UP2 -- solid work, and the external-snapshotter v8.6.0 pinning detail is exactly the kind of gotcha this needs to handle. This work is the core of a CNCF LFX Mentorship 2026 Term 3 project (#7507), so I'm going to hold off on merging until the mentee is selected, to keep the project available for them. I'll keep this open as a reference. If you're interested, applications open Aug 3-18 on the LFX platform. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
The kind matrix excludes every Snapshot and CSI label because the cluster has no CSI driver, so the CSI tests that already exist have never run. This installs the external-snapshotter CRDs, the snapshot-controller and csi-driver-host-path, then adds a job that runs the BackupVolumeInfo CSI labels against them.
The kind StorageClass moves to the hostpath provisioner in the same change, since local-path cannot snapshot and switching it before the driver exists would leave PVCs unbound in the jobs that pass today.
external-snapshotter is pinned to v8.6.0 deliberately. The bundled csi-snapshotter v8.6.0 sidecar watches groupsnapshot.storage.k8s.io/v1, which older CRD sets do not serve, so with the group snapshot gate on it never finishes syncing its caches and processes nothing — ordinary VolumeSnapshots included. It fails silently: readyToUse never becomes true and CreateSnapshot is never called. The install script asserts all four caches populated so a wrong pin fails loudly.
Does your change fix a particular issue?
NONE
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.