Conversation
get-go-version.yaml had drifted from velero core's copy (stuck on actions/checkout@v6 vs core's @v7). Point pr.yaml/push.yml at core's reusable version instead of a local copy that never gets updated. Also adds backport automation (none existed here) and pr-filepath-check (Go module zip filename validation) by calling velero-io/velero's now- reusable versions of those workflows. Adds .github/CODEOWNERS (* @velero-io/Maintainer, matching core) and switches auto_assign_prs.yml to call core's reusable version, which adds a CODEOWNERS-aware re-request-review job this repo didn't have before. Removes auto_request_review.yml (necojackarc/auto-request-review), which duplicated reviewer-requesting against the same auto-assignees.yml that the centralized auto_assign_prs.yml already handles -- keeping both would double-request reviewers on every PR. Note: backport won't function until "Allow GitHub Actions to create and approve pull requests" is enabled under this repo's Settings > Actions (tracked in velero-io/velero#9603) -- same setting is also blocking on velero-io/velero itself right now. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Member
Author
|
/kind changelog-not-required Note Responses generated with Claude |
This was referenced Aug 14, 2026
Both called workflows (velero-io/velero's backport.yml and auto_assign_prs.yml) only reference secrets.GITHUB_TOKEN, which is auto-generated per-run and already flows to reusable-workflow calls regardless of secrets: inherit. Keeping secrets: inherit granted the called workflow every secret this repo holds (DOCKER_USER, DOCKER_PASSWORD, CODECOV_TOKEN) for no functional benefit -- if velero-io/velero's main branch is ever compromised, that widened the blast radius to this repo's secrets too. Dropping it narrows the called workflow to only what it actually uses. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
4 tasks
sseago
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Points this repo at velero-io/velero's shared reusable workflows instead of maintaining drifted local copies:
get-go-version.yamlhad already drifted from core's copy (stuck onactions/checkout@v6vs core's@v7).pr.yaml/push.ymlnow callvelero-io/velero/.github/workflows/get-go-version.yaml@maininstead of a local file./backport <branch>//cherrypick <branch>comments, or abackport <branch>label) viavelero-io/velero/.github/workflows/backport.yml@main— this repo had none before.pr-filepath-check.yml(Go module zip filename validation) via the same reusable-workflow pattern — also new for this repo..github/CODEOWNERS(* @velero-io/Maintainer, matching core) and switchesauto_assign_prs.ymlto call core's reusable version, which adds a CODEOWNERS-aware re-request-review job this repo didn't have.auto_request_review.yml(necojackarc/auto-request-review), which duplicated reviewer-requesting against the sameauto-assignees.ymlthat the centralizedauto_assign_prs.ymlalready handles — keeping both would double-request reviewers on every PR.Known blocker: backport won't actually create PRs until "Allow GitHub Actions to create and approve pull requests" is enabled under this repo's
Settings > Actions > General. Tracked in velero-io/velero#9603 — same setting is blocking on velero-io/velero itself right now too.Companion PR on velero-io/velero: velero-io/velero#10281 (must merge first — these wrappers call
@mainon that repo).Does your change fix a particular issue?
Related to velero-io/velero#9603
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR. — will comment after opening; CI/infra-only, no user-facing behavior change.site/content/docs/main. — N/A, no user-facing docs affected.Note
Responses generated with Claude