Skip to content

fix(parser): accept mismatched terminal codes - #169

Merged
veeso merged 1 commit into
mainfrom
agent/fix-multiline-replies
Jul 13, 2026
Merged

fix(parser): accept mismatched terminal codes#169
veeso merged 1 commit into
mainfrom
agent/fix-multiline-replies

Conversation

@veeso

@veeso veeso commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Description

Restores the intent of #168 by accepting non-standard multiline FTP replies whose terminal line uses a different three-digit status code. The parser now returns that terminal status in the sync, Tokio, and smol backends while preserving the existing FEAT flow, where the 211- opener must be returned before feature lines are read. This supports servers such as glFTPd without regressing FEAT parsing.

Adds deterministic regression tests for mismatched terminal codes and FEAT parsing across all three backends.

Related to #168.

Checklist

  • I have read the AI Policy and the contributing guidelines.
  • I have added rustdoc documentation for any new public API.
  • I have added tests covering my changes.
  • just check_code passes locally.
  • My commits follow the Conventional Commits format (the CHANGELOG.md is generated from them at release time).

AI Disclosure

OpenAI Codex was used to inspect PR #168, reason about the FEAT regression, implement and test the fix, and prepare this commit and PR. I reviewed the diff and test results and take responsibility for the contribution.

Accept non-standard multiline replies that finish with a different status code while preserving FEAT continuation handling.
@cocogitto-bot

cocogitto-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

✔️ e2b4d97 - Conventional commits check succeeded.

@veeso veeso added the bug Something isn't working label Jul 13, 2026
@veeso
veeso marked this pull request as ready for review July 13, 2026 16:08
@veeso
veeso merged commit ddaf108 into main Jul 13, 2026
66 checks passed
@veeso
veeso deleted the agent/fix-multiline-replies branch July 13, 2026 16:11
@veeso

veeso commented Jul 13, 2026

Copy link
Copy Markdown
Owner Author

Thanks for #168 @elirancv, it was mostly correct, just not covering the FEAT command case. Sorry for the late response; it's been on my to-do list for a couple of weeks, but I was planning to work on it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant