ci: build all feature sets on windows and macos - #165
Merged
Conversation
Extend the build job with an os matrix (ubuntu, windows, macos) so every feature combination is compiled on all three platforms, catching platform-specific build breaks. Coverage/tests stay linux-only as they require Docker.
veeso
force-pushed
the
ci/build-windows-macos
branch
from
June 29, 2026 09:57
aacaae6 to
0f8b1ee
Compare
|
✔️ 0f8b1ee - Conventional commits check succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The library is built in CI on Linux only. That means a build that works on Linux but breaks on Windows or macOS can slip through unnoticed, as happened with the Tokio plus native-tls code that did not compile on Windows.
This change builds every supported feature combination on Linux, Windows and macOS, so a platform specific build failure is caught before merge. The test suite and coverage stay on Linux only because they need Docker, which is not available on the Windows and macOS runners.
Checklist
just check_codepasses locally.CHANGELOG.mdis generated from them at release time).AI Disclosure
I used Claude Code to add the operating system matrix to the build job and to validate the workflow with zizmor. I reviewed the change myself.