fix: add heartbeats to close dead connections, also improve live reload script - #57
Merged
Merged
Conversation
|
✔️ cf01411 - Conventional commits check succeeded. |
schonfinkel
commented
Jun 6, 2026
Owner
|
I'll give it a look today. I'm sorry for the late response; for some reason, I wasn't subscribed to this repo, so I didn't receive any notifications. |
veeso
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is my attempt to solve an issue I originally reported at #53, I decided to also add a heartbeat to the dev web server and that seems to properly handle the dead connections now. Here's an example below:
watch -n 1 ss -tn 'sport = :3000'in the first terminal.I added comments in certain parts of the fix, as I changed the signatures of
sse_initandsse_loop, I can go back and use theResult-based approach, but it really didn't make any sense that this type should be aResult, since this is an internal module no users are impacted.