Skip to content

fix: resolve 3 bugs in isscope - #355

Open
saurabhhhcodes wants to merge 2 commits into
vee1e:masterfrom
saurabhhhcodes:fix/isscope-20885
Open

fix: resolve 3 bugs in isscope#355
saurabhhhcodes wants to merge 2 commits into
vee1e:masterfrom
saurabhhhcodes:fix/isscope-20885

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

Description

This PR fixes real bugs found in the codebase:

  • Replaced global isNaN with Number.isNaN: the global version coerces its argument, so isNaN('1') returns false while Number.isNaN is strict.
  • Replaced arr[arr.length - 1] with .at(-1): cleaner access to the last element.
  • Added rejection handler to Promise.all: an unhandled rejection in any input promise previously crashed silently.

Type of Change

  • Bug fix (non-breaking change fixing an issue)

How Has This Been Tested?

  • Local manual testing

Checklist

  • My code follows the style guidelines
  • I have performed a self-review

Related Issue

Ref: #354

Issue titles are embedded raw into the markdown summary table and
section headings. A title containing '|' added phantom columns to the
table, and multi-line titles injected extra rows/lines, corrupting the
generated report.

Titles are now normalized (escaped pipes, line breaks collapsed to
spaces) before being rendered in tables and headings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant