Skip to content

fix: resolve 1 bugs in isscope - #254

Open
saurabhhhcodes wants to merge 1 commit into
vee1e:masterfrom
saurabhhhcodes:fix/isscope-29403
Open

fix: resolve 1 bugs in isscope#254
saurabhhhcodes wants to merge 1 commit into
vee1e:masterfrom
saurabhhhcodes:fix/isscope-29403

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

Description

This PR fixes real bugs found in the codebase:

  • Added rejection handler to Promise.all: an unhandled rejection in any input promise previously crashed silently.

Type of Change

  • Bug fix (non-breaking change fixing an issue)

How Has This Been Tested?

  • Local manual testing

Checklist

  • My code follows the style guidelines
  • I have performed a self-review

Related Issue

Ref: #253

@saurabhhhcodes saurabhhhcodes mentioned this pull request Aug 5, 2026
4 tasks
fetchWithRetry ignored GitHub's Retry-After header on rate-limit
responses, burning attempts with a fixed backoff on 429s and waiting
for the full X-RateLimit-Reset window on 403s even when the header
suggested a shorter wait. Non-rate-limit 403s (e.g. insufficient
scopes) were also retried, delaying the real error.

Rate-limit waits now prefer Retry-After, fall back to the reset
window for exhausted limits, and non-rate-limit 403s fail fast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant