Skip to content

fix: resolve 1 bugs in isscope - #252

Open
saurabhhhcodes wants to merge 1 commit into
vee1e:masterfrom
saurabhhhcodes:fix/isscope-97348
Open

fix: resolve 1 bugs in isscope#252
saurabhhhcodes wants to merge 1 commit into
vee1e:masterfrom
saurabhhhcodes:fix/isscope-97348

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

Description

This PR fixes real bugs found in the codebase:

  • Added rejection handler to Promise.all: an unhandled rejection in any input promise previously crashed silently.

Type of Change

  • Bug fix (non-breaking change fixing an issue)

How Has This Been Tested?

  • Local manual testing

Checklist

  • My code follows the style guidelines
  • I have performed a self-review

Related Issue

Ref: #251

Clearing the max-issues number input produces NaN, which Math.min/max
propagate straight into maxIssues. With maxIssues = NaN every
comparison in the search loop is false, so the app silently fetched
zero issues.

Non-finite values now fall back to the configured default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant